Skip to content

add additional check run methods - #865

Merged
acrobat merged 3 commits into
KnpLabs:2.xfrom
bobeagan:864/update-check-runs
Jul 11, 2020
Merged

add additional check run methods#865
acrobat merged 3 commits into
KnpLabs:2.xfrom
bobeagan:864/update-check-runs

Conversation

@bobeagan

Copy link
Copy Markdown
Contributor

fixes #864

@acrobat

acrobat commented Apr 25, 2020

Copy link
Copy Markdown
Collaborator

Looks good @bobeagan, can you just add some basic tests to have some coverage for these methods? Thanks!

@GrahamCampbell

Copy link
Copy Markdown
Contributor

This needs re-targetting to 2.x.

@acrobat
acrobat changed the base branch from master to 2.x July 11, 2020 15:40
@acrobat
acrobat merged commit 0e74e30 into KnpLabs:2.x Jul 11, 2020
@acrobat

acrobat commented Jul 11, 2020

Copy link
Copy Markdown
Collaborator

I've added the missing tests and changed the base branch. Thanks @bobeagan for the initial work!

acrobat added a commit that referenced this pull request Jul 11, 2020
* 2.x:
  Update changelog for 2.15.0 release
  Remove description line from changelog to allow automatic update
  feature #865 add additional check run methods (bobeagan, acrobat)
@bobeagan
bobeagan deleted the 864/update-check-runs branch July 17, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update checks / check-runs support

3 participants